Attention is currently required from: fixeria.
dexter has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmo-sccp/+/35999?usp=email )
Change subject: [RFC] osmo_sccp_simple_{client,server}(): allow passing
trans_proto
......................................................................
Patch Set 4: Code-Review+1
(1 comment)
File src/sccp_user.c:
https://gerrit.osmocom.org/c/libosmo-sccp/+/35999/comment/38596b20_291c5175
PS4, Line 729: enum osmo_ss7_asp_protocol proto,
You seem to call the parameter sometimes "proto" and sometimes "trans_proto",
(e.g. in osmo_sccp_simple_client_on_ss7_id2 its "trans_proto"
--
To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/35999?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Change-Id: Ife62326daedaa3bf2f4d1fbff596ead209cb3656
Gerrit-Change-Number: 35999
Gerrit-PatchSet: 4
Gerrit-Owner: fixeria <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <[email protected]>
Gerrit-Attention: fixeria <[email protected]>
Gerrit-Comment-Date: Tue, 27 Feb 2024 15:31:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
