jolly has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmo-sccp/+/35070?usp=email )

Change subject: xua + ipa: Add support for I/O in OSMO_IO mode
......................................................................


Patch Set 9:

(1 comment)

File src/osmo_ss7_asp.c:

https://gerrit.osmocom.org/c/libosmo-sccp/+/35070/comment/64c6fa71_42b7d877
PS9, Line 867:  if (rc < 0) {
> How is this supposed to happen now with osmo_io? It's still not clear to me. 
> […]
Yes, it is done automatically. See stream_srv_iofd_read_cb() at stream_srv.c at 
libosmo-netif. It calls osmo_stream_srv_destroy(). Because the callback 
function is set, ss7_asp_xua_srv_conn_closed_cb will be closed in this case.



--
To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/35070?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Change-Id: I7d02037990f4af405839309510dc6c04e36c3369
Gerrit-Change-Number: 35070
Gerrit-PatchSet: 9
Gerrit-Owner: laforge <lafo...@osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillm...@sysmocom.de>
Gerrit-Reviewer: fixeria <vyanits...@sysmocom.de>
Gerrit-Reviewer: laforge <lafo...@osmocom.org>
Gerrit-Reviewer: pespin <pes...@sysmocom.de>
Gerrit-CC: jolly <andr...@eversberg.eu>
Gerrit-Comment-Date: Thu, 07 Mar 2024 09:59:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pes...@sysmocom.de>
Gerrit-MessageType: comment

Reply via email to