Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/36081?usp=email )
Change subject: Introduce concept of per-HNB persistent data structure ...................................................................... Patch Set 3: (1 comment) File src/osmo-hnbgw/hnbgw_vty.c: https://gerrit.osmocom.org/c/osmo-hnbgw/+/36081/comment/8ee08c8b_e745aa8d PS2, Line 825: "hnb UMTS_CELL_ID", > why doing it this way instead of doing it like in osmo-bsc? Just wondering, > I'm fine with this too. the way we do it in the BSC was based around the idea that there is a 0-255 bts_nr, which in turn has its basis in TS 12.21 OML. Here we don't have an equivalent to that. Any number/index we come up with is completely arbitrary. So rather than inventing some new number that is not resembled anywhere, lets use something that appears in reality. That's either the umts cell identity, or the identity string sent during HNBAP register. I originally had used the identity string in an earlier version of the patch, but during discussion with a customer I had to agree with them that the "UMTS CGI equivalent" is the better _primary key_, as it is unique for each cell in the network. The identity string of the hNodeB is something usually determined by the manufacturer, and it has no inherent meaning to the operator (like MAC-address derived strings, manufacturer serial numbers, ...) -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/36081?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: Ife89a7a206836bd89334d19d3cf8c92969dd74de Gerrit-Change-Number: 36081 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <[email protected]> Gerrit-Attention: pespin <[email protected]> Gerrit-Comment-Date: Thu, 07 Mar 2024 17:46:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <[email protected]> Gerrit-MessageType: comment
