Attention is currently required from: neels.

pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmo-pfcp/+/36348?usp=email )

Change subject: add osmo_pfcp_ip_addrs_get
......................................................................


Patch Set 1:

(1 comment)

File src/libosmo-pfcp/pfcp_msg.c:

https://gerrit.osmocom.org/c/libosmo-pfcp/+/36348/comment/79c70236_7713c0be
PS1, Line 523:                  *v4 = (struct osmo_sockaddr){};
you probably want to set sa_family to AF_UNSPEC here.
If you can find somewhere that it's specified that AF_UNSPEC is 0 then it's 
fine.



--
To view, visit https://gerrit.osmocom.org/c/libosmo-pfcp/+/36348?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-pfcp
Gerrit-Branch: master
Gerrit-Change-Id: I4338a83f26ef2443f90cf835621e73aed5eac521
Gerrit-Change-Number: 36348
Gerrit-PatchSet: 1
Gerrit-Owner: neels <nhofm...@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pes...@sysmocom.de>
Gerrit-Attention: neels <nhofm...@sysmocom.de>
Gerrit-Comment-Date: Tue, 19 Mar 2024 11:43:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

Reply via email to