Attention is currently required from: dexter.
laforge has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmocore/+/36324?usp=email )
Change subject: msgb: Also copy msgb {dst, lchan, cb} during msgb_copy_*
......................................................................
Patch Set 1:
(1 comment)
File src/core/msgb.c:
https://gerrit.osmocom.org/c/libosmocore/+/36324/comment/904c5136_a3bd21eb
PS1, Line 320: * and adjusts the pointers (incl l1h-l4h) accordingly. The cb
part is not copied.
> Now it is copied.
mh, ok. so the old function was *specified* not to copy the cb. That's weird.
ususally msgb is modelled after kernel sk_buff, and there a skb_copy does copy
the cb.
I guess the difficult question here is to detemine if any existing code is
relying on the old behavior or not... If yes, then we should rather introduce a
new function. I'll give it some more thought.
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/36324?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I68328adb952ca8833ba047cb3b49ccc6f8a1f1b5
Gerrit-Change-Number: 36324
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <lafo...@osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pma...@sysmocom.de>
Gerrit-Reviewer: pespin <pes...@sysmocom.de>
Gerrit-Attention: dexter <pma...@sysmocom.de>
Gerrit-Comment-Date: Tue, 19 Mar 2024 13:13:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: dexter <pma...@sysmocom.de>
Gerrit-MessageType: comment
