Attention is currently required from: jolly.

laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmo-netif/+/36354?usp=email )

Change subject: stream_cli.c: Handle read / recvfrom error and close connection
......................................................................


Patch Set 1:

(1 comment)

Patchset:

PS1:
with those kind of corner cases, it would be great to have some kind of test 
coverage.  I wonder what might be the best way to do this... Probably some kind 
of LD_PRELOAD wrapper around the related syscalls to provoke some specific 
error whenever we want that?  At least for the osmo_fd case that should work.  
If any one else has other/better ideas, let me know.



--
To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/36354?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Change-Id: I55426de6b49cb4cb0797e50dfeae11f2efc29b15
Gerrit-Change-Number: 36354
Gerrit-PatchSet: 1
Gerrit-Owner: jolly <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-Attention: jolly <[email protected]>
Gerrit-Comment-Date: Tue, 19 Mar 2024 14:23:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

Reply via email to