Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/36363?usp=email )
Change subject: Convert RTP/RTCP/OSMUX I/O from osmo_fd to osmo_io ...................................................................... Patch Set 1: (2 comments) File src/libosmo-mgcp/mgcp_network.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15252): https://gerrit.osmocom.org/c/osmo-mgw/+/36363/comment/1d6b142a_74778328 PS1, Line 1051: LOGP(DRTP, LOGL_DEBUG, "sending %i bytes length packet to %s ...\n", msgb_length(msg), Use %d instead of %i Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15252): https://gerrit.osmocom.org/c/osmo-mgw/+/36363/comment/9c7a5c75_fc5863d1 PS1, Line 1492: proto = (iofd == conn_src->end.rtp)? MGCP_PROTO_RTP : MGCP_PROTO_RTCP; spaces required around that '?' (ctx:VxW) -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/36363?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I8471960d5d8088a70cf105f2f40dfa5d5458169a Gerrit-Change-Number: 36363 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <[email protected]> Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Tue, 19 Mar 2024 20:23:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
