Attention is currently required from: laforge, msuraev.

fixeria has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-pcap/+/32127?usp=email )

Change subject: contrib/jenkins.sh: build with --enable-external-tests
......................................................................


Patch Set 4:

(1 comment)

Patchset:

PS3:
Not sure if this is intentional, but it's actually `0.1s`:

```
 87                 # possibly the binary hasn't launched yet
 88                 if debug_tcp_sockets:
 89                     print("Connecting socket failed, retrying...")
 90                 time.sleep(.1)
 91                 continue
```

>  So the DH generation would need to take more than 30s for this to trigger 
> the problem?

Taking the above into account, more than 3s. I don't remember all the details, 
but maybe we can make this sleep value configurable and pass a larger value 
here?



--
To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/32127?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcap
Gerrit-Branch: master
Gerrit-Change-Id: Ic9d37b231510e592198a9de707dfe8f5f2703dce
Gerrit-Change-Number: 32127
Gerrit-PatchSet: 4
Gerrit-Owner: fixeria <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-CC: msuraev <[email protected]>
Gerrit-Attention: laforge <[email protected]>
Gerrit-Attention: msuraev <[email protected]>
Gerrit-Comment-Date: Wed, 20 Mar 2024 09:30:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <[email protected]>
Comment-In-Reply-To: fixeria <[email protected]>
Gerrit-MessageType: comment

Reply via email to