Attention is currently required from: dexter, fixeria, neels, pespin.

laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-mgw/+/36361?usp=email )

Change subject: Change msgb ownership in processing of received msgb
......................................................................


Patch Set 2:

(4 comments)

File src/libosmo-mgcp/mgcp_network.c:

https://gerrit.osmocom.org/c/osmo-mgw/+/36361/comment/ad301aa3_943cce0b
PS2, Line 1191: return rc
> missing `msgb_free()`?
Done


https://gerrit.osmocom.org/c/osmo-mgw/+/36361/comment/19047f56_d2d419d4
PS2, Line 1205: return rc
> missing `msgb_free()`?
Done


https://gerrit.osmocom.org/c/osmo-mgw/+/36361/comment/5da3c860_c084573e
PS2, Line 1212: return rc
> missing `msgb_free()`?
Done


File src/libosmo-mgcp/mgcp_osmux.c:

https://gerrit.osmocom.org/c/osmo-mgw/+/36361/comment/e161bcb9_20b45499
PS2, Line 217: return -1;
> missing `msgb_free()` here and below? AFAIU, if a function claims to take 
> ownership, then it's also  […]
Done



--
To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/36361?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Change-Id: I6a331f3c6b2eb51ea312ac6ef8c357185ddb79cf
Gerrit-Change-Number: 36361
Gerrit-PatchSet: 2
Gerrit-Owner: laforge <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <[email protected]>
Gerrit-Reviewer: neels <[email protected]>
Gerrit-Reviewer: pespin <[email protected]>
Gerrit-CC: fixeria <[email protected]>
Gerrit-Attention: neels <[email protected]>
Gerrit-Attention: fixeria <[email protected]>
Gerrit-Attention: pespin <[email protected]>
Gerrit-Attention: dexter <[email protected]>
Gerrit-Comment-Date: Wed, 20 Mar 2024 11:44:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <[email protected]>
Gerrit-MessageType: comment

Reply via email to