Attention is currently required from: laforge, neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-pfcp/+/36347?usp=email )
Change subject: pfcp up_function_features: allow shorter lengths ...................................................................... Patch Set 1: Code-Review+2 (2 comments) File src/libosmo-pfcp/pfcp_ies_custom.c: https://gerrit.osmocom.org/c/libosmo-pfcp/+/36347/comment/4785212e_1fc325f7 PS1, Line 435: * if the peer sends less octets, make do with what we get. */ > https://dictionary.cambridge. […] Thanks I didn't know that one :) https://gerrit.osmocom.org/c/libosmo-pfcp/+/36347/comment/7822fac7_51050479 PS1, Line 436: memset(up_function_features->bits, 0, sizeof(up_function_features->bits)); > where's the second memcpy? you mean avoiding memset and memcpy'ing the same > location? I'm always hop […] Yeah I meant memset+memcpy. -- To view, visit https://gerrit.osmocom.org/c/libosmo-pfcp/+/36347?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-pfcp Gerrit-Branch: master Gerrit-Change-Id: I40e255fd0b4770e578aea7a10ba88f5eeba087f4 Gerrit-Change-Number: 36347 Gerrit-PatchSet: 1 Gerrit-Owner: neels <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-Attention: neels <[email protected]> Gerrit-Attention: laforge <[email protected]> Gerrit-Comment-Date: Wed, 20 Mar 2024 13:12:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: laforge <[email protected]> Comment-In-Reply-To: pespin <[email protected]> Gerrit-MessageType: comment
