Attention is currently required from: osmith. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/36383?usp=email )
Change subject: contrib/jenkins.sh: add 'distcheck' job to check package integrity ...................................................................... Patch Set 2: (2 comments) File contrib/jenkins.sh: https://gerrit.osmocom.org/c/pysim/+/36383/comment/01851ff7_7dfd4a6d PS2, Line 35: "distcheck") > I'm not sure if we should call it "distcheck". It sounds like "make > distcheck" from autotools, but it does something else here. Maybe smoketest? Well, it's a distribution integrity check. Yes, it's not exactly identical to what automake is doing when running `make check`, but still I see nothing wrong calling it this way. Can rename to `smoketest` if you guys like. > If you just want to print --help, maybe just add it at the end of the regular > test job (since it will almost take no extra time, and then you can avoid > having the test setup time)? Or is the idea to extend it later on and do more? No, I am not planning to extend it. I just thought it would be cleaner to have a separate job for this additional check, so that one could quickly see what exactly is causing the build verification failure. The existing `test` is already doing few things: running unit tests, SIM programming tests, and pySim-trace tests. Likewise, if you think it's better to run the smoketest there, I can amend the patch. https://gerrit.osmocom.org/c/pysim/+/36383/comment/4fdb1618_967be187 PS2, Line 43: $prog --help > /dev/null > why >/dev/null, wouldn't it be useful to have the output in jenkins, so one > can take a look at it? Not sure if printing help would this be useful, we're mostly interested to catch errors here. If others find it useful, I can remove the `/dev/null` redirection then. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/36383?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ic72d58494e8fd0cab8d66ce60f7b70593b770872 Gerrit-Change-Number: 36383 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: osmith <[email protected]> Gerrit-CC: char <[email protected]> Gerrit-Attention: osmith <[email protected]> Gerrit-Comment-Date: Fri, 22 Mar 2024 10:03:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <[email protected]> Gerrit-MessageType: comment
