Attention is currently required from: fixeria. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/36446?usp=email )
Change subject: ttcn3-bts-test: abort if missing osmo-config-merge ...................................................................... Patch Set 2: (1 comment) File ttcn3-bts-test/Makefile: https://gerrit.osmocom.org/c/docker-playground/+/36446/comment/0e858517_f2b813b3 PS1, Line 15: cfg req-osmo-config-merge > Ah, indeed. So by doing this you allow the user to do: […] well, it is also allowed without having it in PHONY. The only thing it does, is that if you do: ``` $ touch req-osmo-config-merge $ make osmo-config-merge ``` Then make knows it isn't a real target and it should run anyway, even though the file with the name of the target exists. It's good practice to put it there, for our use case it doesn't make a difference. But since we also have cfg there I put it there as well. -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/36446?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I9cea4affac0b3981c88078581a070f98649da667 Gerrit-Change-Number: 36446 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-Attention: fixeria <[email protected]> Gerrit-Comment-Date: Mon, 25 Mar 2024 13:19:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <[email protected]> Comment-In-Reply-To: fixeria <[email protected]> Gerrit-MessageType: comment
