Attention is currently required from: neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/36452?usp=email )
Change subject: fix VLR evil twin on LU with unknown TMSI ...................................................................... Patch Set 1: (3 comments) Commit Message: https://gerrit.osmocom.org/c/osmo-msc/+/36452/comment/344f85e7_d4a0d87a PS1, Line 15: be discarded, for the benefit of the new one. we do the same in osmo-pcu with tbfs btw (ms_merge_and_clear_ms()). File src/libmsc/paging.c: https://gerrit.osmocom.org/c/osmo-msc/+/36452/comment/16cfd6af_fe5db9e1 PS1, Line 147: vlr_subscr_put(discarding_vsub, VSUB_USE_PAGING); Shouldn't this happen only "if discarding_vsub->cs.is_paging"? File src/libvlr/vlr.c: https://gerrit.osmocom.org/c/osmo-msc/+/36452/comment/ca39f788_f7e3f283 PS1, Line 597: struct vlr_instance *vlr = exists->vlr; I'd rpobably move all this code to its own function "vsub_join()" or alike. -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/36452?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ifdabe0b65bffafbf7b8e5cc10e2d225d1ed1cecd Gerrit-Change-Number: 36452 Gerrit-PatchSet: 1 Gerrit-Owner: neels <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <[email protected]> Gerrit-CC: laforge <[email protected]> Gerrit-CC: pespin <[email protected]> Gerrit-Attention: neels <[email protected]> Gerrit-Comment-Date: Tue, 26 Mar 2024 10:26:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
