Attention is currently required from: dexter.

laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36503?usp=email )

Change subject: HTTP_Adapter: add HOST field to header lines.
......................................................................


Patch Set 1: Code-Review+1

(2 comments)

File library/HTTP_Adapter.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36503/comment/15bd9ad3_0caaca51
PS1, Line 55: ts_HTTP_Header
> here the problem actually gets worse as the template is used within the 
> module itself, and even if t […]
nevermind, you are doing that in the followign patch.


https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36503/comment/36e8d1fb_912eb542
PS1, Line 42: application
> the json content-type is specific to a JSON based REST interface, and not 
> generic. […]
nevermind, you are doing that in the followign patch.



--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36503?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Id4b2220da4b2b5fbe74cdc2776cf66d6b34ddbcf
Gerrit-Change-Number: 36503
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-Reviewer: pespin <[email protected]>
Gerrit-Attention: dexter <[email protected]>
Gerrit-Comment-Date: Tue, 02 Apr 2024 18:00:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: laforge <[email protected]>
Gerrit-MessageType: comment

Reply via email to