Attention is currently required from: osmith. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/36507?usp=email )
Change subject: esim.es2p: Permit ApiParamInteger to be an actual integer ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > Maybe this is already done somewhere, but if not: it would probably be a good > idea to explicitly tur […] The function is typically used for input validation. ApiParamBase.decode() method first calls verify_encoded(), then _decode(), then verify_decoded(). So verify_decoded is just made a bit more input tolerant. The output type of the overall ApiParamBase.decode() is always an int. For encoding: the encode() method returns str(data) and hence always a string, as you request -- To view, visit https://gerrit.osmocom.org/c/pysim/+/36507?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I5b47f8bba01225d53eff2ca086e53a2133abed7f Gerrit-Change-Number: 36507 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <[email protected]> Gerrit-Attention: osmith <[email protected]> Gerrit-Comment-Date: Fri, 05 Apr 2024 11:42:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <[email protected]> Gerrit-MessageType: comment
