Attention is currently required from: neels.

pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-hnbgw/+/36540?usp=email )

Change subject: nft_kpi: retrieve counters in a separate thread
......................................................................


Patch Set 3:

(1 comment)

Patchset:

PS3:
> This is a very generalised statement that seems to be an opinion, and not a 
> hard fact. Let's stay here in this patch.

This may be an opinion to you, but to me it's a hard fact when using 
production-grade code using a main loop handling hundreds of peers and 
thousands of subscribers.

TBH, since most of my comments seem to be discarded with "it's bikeshed" or 
"it's an opinion" from you, I'm really fed up and considering stopping what you 
consider "bikesheding" and let others review your patches until you get your 
+2, so at least I don't end up losing my time again and again providing 
feedback.



--
To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/36540?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-hnbgw
Gerrit-Branch: master
Gerrit-Change-Id: I9dc54e6bc94c553f45adfa71ae8ad70be4afbc8f
Gerrit-Change-Number: 36540
Gerrit-PatchSet: 3
Gerrit-Owner: neels <nhofm...@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <lafo...@osmocom.org>
Gerrit-CC: pespin <pes...@sysmocom.de>
Gerrit-Attention: neels <nhofm...@sysmocom.de>
Gerrit-Comment-Date: Mon, 15 Apr 2024 16:18:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: neels <nhofm...@sysmocom.de>
Gerrit-MessageType: comment

Reply via email to