Attention is currently required from: daniel, osmith, pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/36590?usp=email )
Change subject: ttcn3-hnbgw: Apply latest changes to 'with-pfcp' scenario ...................................................................... Patch Set 1: (1 comment) File ttcn3-hnbgw-test/with-pfcp/HNBGW_Tests.cfg: https://gerrit.osmocom.org/c/docker-playground/+/36590/comment/2dd6d0cf_bfea053b PS1, Line 120: + > this "+" seems to be a copy paste bug -- let me guess, you haven't actually > tested this patch... (then again not so trivial to test docker-playground patches, at first thought this was osmo-ttcn3-hacks) This seems to duplicate hnbgw.cfg item 'timer X31' -- IMHO we should have one fixed config in osmo-hnbgw.cfg, or only ttcn3 code that adjusts config via VTY. This here says it keeps a value in sync with a .cfg file, so is it being duplicated? I'd favor avoiding that duplication... fine if it's too late / unrelated -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/36590?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Ie02a0754a6ca985e60e08f1f171f532b6cc16264 Gerrit-Change-Number: 36590 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <[email protected]> Gerrit-Reviewer: fixeria <[email protected]> Gerrit-Reviewer: neels <[email protected]> Gerrit-Reviewer: osmith <[email protected]> Gerrit-Attention: osmith <[email protected]> Gerrit-Attention: pespin <[email protected]> Gerrit-Attention: daniel <[email protected]> Gerrit-Comment-Date: Wed, 17 Apr 2024 19:46:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <[email protected]> Gerrit-MessageType: comment
