Attention is currently required from: fixeria, osmith.

pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36589?usp=email )

Change subject: sgsn: add testcases for SGSN Context Request procedure
......................................................................


Patch Set 2:

(2 comments)

File sgsn/SGSN_Tests.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36589/comment/fd99ae9e_6aff6fd3
PS2, Line 3807:                 log("Rx SGSN Context Request from SGSN: ", 
gtpc_ud.gtpc);
This log is most probably not needed, only polluting output.


https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36589/comment/5090ea49_347399de
PS2, Line 3852:                 log("Rx SGSN Context ACK from SGSN: ", 
gtpc_ud.gtpc);
same, not needed.



--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36589?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: If71de10897a8a9f6612cd46c760cd89c0299ac2c
Gerrit-Change-Number: 36589
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <[email protected]>
Gerrit-Reviewer: pespin <[email protected]>
Gerrit-Attention: osmith <[email protected]>
Gerrit-Attention: fixeria <[email protected]>
Gerrit-Comment-Date: Thu, 18 Apr 2024 22:28:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

Reply via email to