Attention is currently required from: fixeria.

pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36601?usp=email )

Change subject: sgsn: TC_sgsn_context_req_in: match PDP Context IE
......................................................................


Patch Set 3:

(2 comments)

File library/GTPv1C_Templates.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36601/comment/5bde6f36_cfa65846
PS3, Line 473:          lengthf := ?, /* overwritten */
These overwritten stuff doesn't make much sense here, should be dropped.


File sgsn/SGSN_Tests.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36601/comment/64d89e44_b2e05cbc
PS3, Line 3765:         pdp_ctx.pdp_typeorg := apars.addr.pdpTypeOrg;
All these should be passed in tr_PDP_Context_GTPC.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36601?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I965c0200ea380c55dc0cd8d3f8e5110883ce2646
Gerrit-Change-Number: 36601
Gerrit-PatchSet: 3
Gerrit-Owner: fixeria <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <[email protected]>
Gerrit-Attention: fixeria <[email protected]>
Gerrit-Comment-Date: Thu, 18 Apr 2024 22:35:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

Reply via email to