Attention is currently required from: daniel, fixeria, fixeria, laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36601?usp=email )
Change subject: sgsn: TC_sgsn_context_req_in: match PDP Context IE ...................................................................... Patch Set 6: (1 comment) File sgsn/SGSN_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36601/comment/a2cf2328_a5c8b135 PS6, Line 3748: f_pdp_ctx_act(apars); > I don't think it really matters for this specific test scenario whether the > requested IP address mat […] @axilira...@gmail.com I think it makes sense to validate the whole scenario as closely as it will usually run. That means MS requesting dynamic address. This may affect the code logic inside osmo-sgsn, turning it into a specific state where the IP address passed later on in the newly added messages may affect. A) To me that looks like a bug in osmo-sgsn, because afaiu the MS got an IP address assigned from GGSN previously right? Why is it not proividing the IP address to the MME then? Something seems really odd here and we need to agree on what's going first. Please avoid merging this patch until we are all on the same track, I agree it makes no sense to encode an empty PDP Address in SGSN Context Response. After all, a properly established pdp context should have a valid address (assigned by GGSN). If there's no valid IP address (it shouldn't happen in first place? maybe because pdp ctx creation is ongoing with GGSN?), then the SGSN should refrain from sending that PDP Context in the list, as I think is explained somewhere in the specs iirc. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36601?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I965c0200ea380c55dc0cd8d3f8e5110883ce2646 Gerrit-Change-Number: 36601 Gerrit-PatchSet: 6 Gerrit-Owner: fixeria <vyanits...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <lafo...@osmocom.org> Gerrit-Reviewer: osmith <osm...@sysmocom.de> Gerrit-Reviewer: pespin <pes...@sysmocom.de> Gerrit-CC: daniel <dwillm...@sysmocom.de> Gerrit-CC: fixeria <axilira...@gmail.com> Gerrit-Attention: laforge <lafo...@osmocom.org> Gerrit-Attention: fixeria <vyanits...@sysmocom.de> Gerrit-Attention: daniel <dwillm...@sysmocom.de> Gerrit-Attention: fixeria <axilira...@gmail.com> Gerrit-Comment-Date: Mon, 22 Apr 2024 12:35:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <lafo...@osmocom.org> Comment-In-Reply-To: fixeria <vyanits...@sysmocom.de> Comment-In-Reply-To: pespin <pes...@sysmocom.de> Gerrit-MessageType: comment
