Attention is currently required from: laforge.

tnt has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-e1d/+/36653?usp=email )

Change subject: iCE1usb: Add support to configure CRC4 mode for TX/RX
......................................................................


Patch Set 1:

(1 comment)

File src/vty.c:

https://gerrit.osmocom.org/c/osmo-e1d/+/36653/comment/012c4c7d_0303d0b1
PS1, Line 434: framing-tx (no-crc4|crc4)",
> this could be one command for both rx and tx like "framing (rx|tx) 
> (no-crc4|crc4)". […]
Ack, will change.

I was trying to change it to "framing [(tx|rx)] (no-crc4|crc4)" so that you 
could just do both at once, but that doesn't see to work. Is optional middle 
argument not supported ?



--
To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/36653?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-e1d
Gerrit-Branch: master
Gerrit-Change-Id: I9b627a9617af4ae9ed98214d672c7d0391f801eb
Gerrit-Change-Number: 36653
Gerrit-PatchSet: 1
Gerrit-Owner: tnt <t...@246tnt.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <lafo...@osmocom.org>
Gerrit-Attention: laforge <lafo...@osmocom.org>
Gerrit-Comment-Date: Sun, 28 Apr 2024 12:19:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <lafo...@osmocom.org>
Gerrit-MessageType: comment

Reply via email to