Attention is currently required from: laforge, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/36761?usp=email )
Change subject: tests/osmo-bts.vty: aligh with recent libosmovty changes ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > What if I build an old osmo-bts with new libosmocore? It would build just fine and pass the unit tests, but not the vty transcript test. I am not really sure if we can fix this in the python script, or more precisely **how**. It's simply executing commands and matching the program output against the expected output. We cannot just change the script to ignore spacing, as that would break other stuff. Maybe @[email protected] has an idea? -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/36761?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I80f896e45a88550909c5767169286fc321a36e56 Gerrit-Change-Number: 36761 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: osmith <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-CC: neels <[email protected]> Gerrit-Attention: laforge <[email protected]> Gerrit-Attention: pespin <[email protected]> Gerrit-Comment-Date: Fri, 10 May 2024 10:23:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <[email protected]> Comment-In-Reply-To: pespin <[email protected]> Gerrit-MessageType: comment
