Attention is currently required from: fixeria, laforge, neels.

pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-msc/+/36760?usp=email )

Change subject: libmsc: add X5 timer for delaying LU transactions
......................................................................


Patch Set 2:

(1 comment)

File src/libmsc/msc_a.c:

https://gerrit.osmocom.org/c/osmo-msc/+/36760/comment/9542b60e_8268fa81
PS2, Line 192:  osmo_timer_schedule(&msc_a->lu_delay_timer, Tval, 0);
> are you sure the object cannot be destroyed in any way while the timer is 
> set? […]
Maybe to be on the safe side locate the use_count_free/release to talloc_free 
callback and make sure to deregister the timer.



--
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/36760?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: Ic519cab55d65e47b2636124427dab1a1d80fab78
Gerrit-Change-Number: 36760
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-Reviewer: neels <[email protected]>
Gerrit-Reviewer: pespin <[email protected]>
Gerrit-Attention: neels <[email protected]>
Gerrit-Attention: laforge <[email protected]>
Gerrit-Attention: fixeria <[email protected]>
Gerrit-Comment-Date: Fri, 10 May 2024 14:00:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <[email protected]>
Gerrit-MessageType: comment

Reply via email to