Attention is currently required from: laforge, pespin.

osmith has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36755?usp=email )

Change subject: asterisk: Implement AMI_Adapter using IPL4 instead of TELNET
......................................................................


Patch Set 4: Code-Review+2

(1 comment)

File asterisk/AMI_Functions.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36755/comment/8bd97d5e_48a81288
PS3, Line 260:  /* TEXT Enc/dec is not happy with values containing "; ", get 
rid of them:
             :   * "AppData: 5,0502: Call pjsip endpoint from 0501\r\n" */
             :  var integer pos := f_strstr(patched_txt, "AppData: ", 0);
             :  if (pos >= 0) {
             :          var integer pos_end := f_strstr(patched_txt, "\r\n", 
pos) + lengthof("\r\n");
             :          var charstring to_remove := substr(patched_txt, pos, 
pos_end - pos);
             :          patched_txt := f_str_replace(patched_txt, to_remove, 
"");
             :  }
> Ack
Done



--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36755?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Icaf2860c1dd4befa4498f0d176cfadf26cfa8d1d
Gerrit-Change-Number: 36755
Gerrit-PatchSet: 4
Gerrit-Owner: pespin <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-Reviewer: osmith <[email protected]>
Gerrit-Attention: laforge <[email protected]>
Gerrit-Attention: pespin <[email protected]>
Gerrit-Comment-Date: Fri, 10 May 2024 14:24:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: osmith <[email protected]>
Comment-In-Reply-To: pespin <[email protected]>
Gerrit-MessageType: comment

Reply via email to