Attention is currently required from: osmith.
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-ggsn/+/36068?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Verified-1 by Jenkins Builder
Change subject: gtp/gtp_internal.h: new file
......................................................................
gtp/gtp_internal.h: new file
While at it, move internal functions of gtp.h to a separate file too.
Make all functions that are only used inside gtp.c static.
The following APIs are unexpectedly public:
* imsi_gtp2str gets used by pdp.h
* gsna2in_addr, gtp_echo_req gets used by osmo-sgsn
Change-Id: I72c40cbdec33449ca8104fb3cad8df1a9e07dfd7
---
M ggsn/ggsn.c
M ggsn/ggsn_vty.c
M ggsn/sgsn.c
M gtp/Makefile.am
M gtp/gtp.c
A gtp/gtp_internal.h
M include/osmocom/gtp/gtp.h
M sgsnemu/sgsnemu.c
8 files changed, 54 insertions(+), 77 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ggsn refs/changes/68/36068/2
--
To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/36068?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ggsn
Gerrit-Branch: master
Gerrit-Change-Id: I72c40cbdec33449ca8104fb3cad8df1a9e07dfd7
Gerrit-Change-Number: 36068
Gerrit-PatchSet: 2
Gerrit-Owner: osmith <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <[email protected]>
Gerrit-Attention: osmith <[email protected]>
Gerrit-MessageType: newpatchset
