Attention is currently required from: jolly, pespin.

osmith has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36856?usp=email )

Change subject: asterisk: Implement support to handle 2nd REGISTER through ipsec
......................................................................


Patch Set 2: Code-Review+1

(2 comments)

File asterisk/IMS_ConnectionHandler.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36856/comment/36283d93_2b884af0
PS2, Line 471: Tyring
Trying


File asterisk/IMS_ipsec_setup.sh:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36856/comment/c2750d61_4440b97e
PS2, Line 29:         src "${1}" dst "${3}" proto esp spi "${5}" reqid "${5}" 
mode transport \
            :         replay-window 32 \
            :         auth-trunc sha1 "${AUTH_KEY}" 96 \
            :         enc cipher_null "" \
            :         sel src "${1}/32" dst "${3}/32" sport "${2}" dport "${4}"
indentation: should have 1 more tab, same in ip_xfrm_policy



--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36856?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ic042422788ee406f5b71ca3878bc5617e5455579
Gerrit-Change-Number: 36856
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: jolly <[email protected]>
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-Reviewer: osmith <[email protected]>
Gerrit-Attention: jolly <[email protected]>
Gerrit-Attention: pespin <[email protected]>
Gerrit-Comment-Date: Fri, 17 May 2024 08:57:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Reply via email to