Patch Set 1: (1 comment)
https://gerrit.osmocom.org/#/c/5892/1/src/libcommon/handover_cfg.c File src/libcommon/handover_cfg.c: Line 30: struct handover_cfg { > Why not to define this structure in header? the parameters should be accessed by the ho_get_* and ho_set_* API, hence I want this struct to remain opaque. The main reason is: I'm adding a network-wide config as well as a per-bts config that defaults to the network-wide one if unset; hence the has_xxx members and looking for set values at higher_level_cfg. Allowing direct access to the members would be opening doors for erratic use. -- To view, visit https://gerrit.osmocom.org/5892 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I79d35f6d3c0fbee67904378ad7f216df34fde79a Gerrit-PatchSet: 1 Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Owner: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: Vadim Yanitskiy <[email protected]> Gerrit-HasComments: Yes
