Attention is currently required from: Hoernchen, lynxis lazus. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/simtrace2/+/36859?usp=email )
Change subject: RFC: card emu config: add feature sim polarity ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Patchset: PS1: looks good to me. Might be worth having #defines for the two bits like ``` #define CEMU_CONFIG_SIMPOL_VALID 0x02 #define CEMU_CONFIG_SIMPOL_PRES_H 0x01 ``` or the like -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/36859?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: I36a8acb74ad7616205af68b1626b45ab79d7cb02 Gerrit-Change-Number: 36859 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lyn...@fe80.eu> Gerrit-Reviewer: Hoernchen <ew...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <lafo...@osmocom.org> Gerrit-Reviewer: lynxis lazus <lyn...@fe80.eu> Gerrit-Attention: Hoernchen <ew...@sysmocom.de> Gerrit-Attention: lynxis lazus <lyn...@fe80.eu> Gerrit-Comment-Date: Tue, 21 May 2024 09:08:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
