neels has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmocore/+/36913?usp=email )

Change subject: add jhash.h, copied from linux/jhash.h
......................................................................


Patch Set 1:

(1 comment)

File include/osmocom/core/jhash.h:

https://gerrit.osmocom.org/c/libosmocore/+/36913/comment/64140e98_c7e682b4
PS1, Line 100:          c += osmo_load32le(k + 8);
RFC, I am uncertain here:

These calls were originally __get_unaligned_cpu32().
osmo_load32le() might be a suboptimal implementation.
Any opinions / insights?



--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/36913?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I0c9652bbc9e2a18b1200e7d63bb6f64ded7d75fa
Gerrit-Change-Number: 36913
Gerrit-PatchSet: 1
Gerrit-Owner: neels <[email protected]>
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-Comment-Date: Thu, 23 May 2024 14:48:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

Reply via email to