Patch Set 1: (1 comment)
https://gerrit.osmocom.org/#/c/5889/1/src/libbsc/bsc_vty.c File src/libbsc/bsc_vty.c: Line 1420: "handover <0-255> <0-255> <0-7> LCHAN_NR <0-255>", > lchan numbers are 0..8 as the lchan[] array is 8 in size. Rationale: SDCCH/ This is actually not an addition, just looks like one from the way the patch is interpreted. The LCHAN_NR argument exists in HEAD. It was probably chosen such because the maximum lchan nr depends on the pchan type; not that that makes a lot of sense. I'll change that separately. Even more interesting is: show lchan [<0-255>] [<0-255>] [<0-7>] [lchan_nr] "lchan_nr" appears to be an optional *string constant*? -- To view, visit https://gerrit.osmocom.org/5889 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9745609f2620baa09a693b713d76e355e798abc7 Gerrit-PatchSet: 1 Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Owner: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-HasComments: Yes
