Attention is currently required from: dexter, fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/36928?usp=email )
Change subject: pySim-shell: Migrate PySimApp.iccid to RuntimeState.identity['ICCID'] ...................................................................... Patch Set 1: Code-Review+2 (1 comment) File pySim-shell.py: https://gerrit.osmocom.org/c/pysim/+/36928/comment/663a89d4_3248cb6a PS1, Line 763: self._cmd.rs.identity['ICCID']) > For the sake of consistency with `ATR`, which is only present in the dict if > available, maybe do not […] I'm not following you. When would we not have the ATR available? If there's no ATR, there's no card, so nothing else will work at all, including cardinfo. For ICCID it is valid to be absent. An eUICC without any enabled eSIM profile will not have an ICCID, so that's a valid use case. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/36928?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ibdcf9a7c4e7e445201640bce33b768bcc4460db1 Gerrit-Change-Number: 36928 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <[email protected]> Gerrit-Reviewer: fixeria <[email protected]> Gerrit-Reviewer: laforge <[email protected]> Gerrit-Attention: fixeria <[email protected]> Gerrit-Attention: dexter <[email protected]> Gerrit-Comment-Date: Thu, 30 May 2024 18:05:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: fixeria <[email protected]> Gerrit-MessageType: comment
