Attention is currently required from: dexter, fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/36930?usp=email )
Change subject: CardKeyProvider: Implement support for column-based transport key encryption ...................................................................... Patch Set 2: (7 comments) Patchset: PS1: > this still needs documentation Done File contrib/csv-encrypt-columns.py: https://gerrit.osmocom.org/c/pysim/+/36930/comment/ad55b606_e45cdf37 PS1, Line 29: def dict_keys_to_upper(d: dict): > typing hint: `-> dict:` Done https://gerrit.osmocom.org/c/pysim/+/36930/comment/5005ea52_4227e858 PS1, Line 37: def encrypt_col(self, colname:str, value: str): > typing hint: `-> Hexstr:`? Done https://gerrit.osmocom.org/c/pysim/+/36930/comment/9c9d92c2_a1ca3a78 PS1, Line 43: def encrypt(self): > type hint: `-> None:` Done https://gerrit.osmocom.org/c/pysim/+/36930/comment/3304b1c3_4b782e61 PS1, Line 60: parser.add_argument('CSVFILE', help="CSV file name") > Idea: you can do `type=argparse. […] I really don't see many stdin/stdout use cases for CSV files [with mandatory header, like here], sorry. https://gerrit.osmocom.org/c/pysim/+/36930/comment/7b48851c_cc608623 PS1, Line 61: default=[], > I would remove `default` and put `required=True`, since you require at least > one argument. Done File pySim/card_key_provider.py: https://gerrit.osmocom.org/c/pysim/+/36930/comment/0660366f_f8e1c4d1 PS1, Line 129: str) -> str > `Hexstr`? No, cannot do here as there are other values passing through [if no transport key, it could be anything non-hex] -- To view, visit https://gerrit.osmocom.org/c/pysim/+/36930?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I13146a799448d03c681dc868aaa31eb78b7821ff Gerrit-Change-Number: 36930 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <[email protected]> Gerrit-Reviewer: fixeria <[email protected]> Gerrit-Attention: fixeria <[email protected]> Gerrit-Attention: dexter <[email protected]> Gerrit-Comment-Date: Thu, 30 May 2024 21:35:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <[email protected]> Comment-In-Reply-To: fixeria <[email protected]> Gerrit-MessageType: comment
