Attention is currently required from: laforge. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/37011?usp=email )
Change subject: add contrib/saip-tool.py ...................................................................... Patch Set 3: Code-Review+1 (2 comments) File contrib/saip-tool.py: https://gerrit.osmocom.org/c/pysim/+/37011/comment/12623f6c_780adba5 PS3, Line 37: subparsers = parser.add_subparsers(dest='command', help="The command to perform", required=True) subparsers.required = True https://gerrit.osmocom.org/c/pysim/+/37011/comment/5a1a7bb7_35788fd3 PS3, Line 99: #pp.pprint(pe.decoded[d]) : #if pe.type in ['akaParameter', 'pinCodes', 'pukCodes']: : # pp.pprint(pe.decoded) do you want to keep this? -- To view, visit https://gerrit.osmocom.org/c/pysim/+/37011?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I396bcd594e0628dfc26bd90233317a77e2f91b20 Gerrit-Change-Number: 37011 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <[email protected]> Gerrit-Attention: laforge <[email protected]> Gerrit-Comment-Date: Fri, 07 Jun 2024 10:22:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
