laforge has submitted this change. (
https://gerrit.osmocom.org/c/osmo-bsc/+/36989?usp=email )
Change subject: silence error message for N-STATE prim
......................................................................
silence error message for N-STATE prim
We ignore the N-STATE prim, so don't error about it.
While at it, improve the "unhandled" error message (according to code
review).
Related: SYS#6952
Change-Id: Ic353840a7b2e32c54c2732f58836776a5eddb220
---
M src/osmo-bsc/osmo_bsc_sigtran.c
1 file changed, 24 insertions(+), 2 deletions(-)
Approvals:
Jenkins Builder: Verified
laforge: Looks good to me, approved
fixeria: Looks good to me, but someone else must approve
diff --git a/src/osmo-bsc/osmo_bsc_sigtran.c b/src/osmo-bsc/osmo_bsc_sigtran.c
index a1aaaaf..224e2c6 100644
--- a/src/osmo-bsc/osmo_bsc_sigtran.c
+++ b/src/osmo-bsc/osmo_bsc_sigtran.c
@@ -363,9 +363,16 @@
handle_pcstate_ind(osmo_sccp_get_ss7(sccp),
&scu_prim->u.pcstate);
break;
+ case OSMO_PRIM(OSMO_SCU_PRIM_N_STATE, PRIM_OP_INDICATION):
+ LOGP(DMSC, LOGL_DEBUG, "SCCP-User-SAP: Ignoring %s.%s\n",
+ osmo_scu_prim_type_name(oph->primitive),
+ get_value_string(osmo_prim_op_names, oph->operation));
+ break;
+
default:
- LOGP(DMSC, LOGL_ERROR, "Unhandled SIGTRAN operation %s on
primitive %s\n",
- get_value_string(osmo_prim_op_names, oph->operation),
osmo_scu_prim_type_name(oph->primitive));
+ LOGP(DMSC, LOGL_ERROR, "SCCP-User-SAP: Unhandled %s.%s\n",
+ osmo_scu_prim_type_name(oph->primitive),
+ get_value_string(osmo_prim_op_names, oph->operation));
break;
}
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/36989?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Ic353840a7b2e32c54c2732f58836776a5eddb220
Gerrit-Change-Number: 36989
Gerrit-PatchSet: 2
Gerrit-Owner: neels <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <[email protected]>
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-Reviewer: osmith <[email protected]>
Gerrit-MessageType: merged
