Attention is currently required from: daniel. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/37192?usp=email )
Change subject: jenkins-common: Treat -asan builds as -master ...................................................................... Patch Set 1: (2 comments) Patchset: PS1: > See https://projects.osmocom.org/issues/6486 […] we can't really categorize it like that, because these require different binary builds: - master (using osmocom:nightly binary packages for libraries, building programs from git master) - asan (using osmocom:nightly:asan binary packages) - latest (using osmocom:latest binary packages) Using uring or not is changed by setting an environment variable. So the asan builds are currently only done for nightly, hence this patch does the right thing. If we also wanted to do asan-latest at one point, then we would need a separate binary repository for that and would need to adjust that function. (in general the architecture of docker-playground.git has grown historically and could use some improvements IMHO, but this is out of scope here) File jenkins-common.sh: https://gerrit.osmocom.org/c/docker-playground/+/37192/comment/a56d6dbc_586c5998 PS1, Line 548: image_suffix_is_master() { How about renaming the function (here and in the once place it is currently used, in ttcn3-stp-test/jenkins.sh): ``` osmo_repo_is_nightly ``` ...to make this more intuitive? The -asan images use the osmocom:nightly:asan repository, and the -master images install libraries from osmocom:nightly (in addition to building programs from git from source). This would also make it more similar to the function we use in osmo-ttcn3-hacks.git: ``` if (f_osmo_repo_is("nightly")) { ``` -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/37192?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Ibf93880345f38668f8dc812d1523b985d368dfcc Gerrit-Change-Number: 37192 Gerrit-PatchSet: 1 Gerrit-Owner: daniel <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-Attention: daniel <[email protected]> Gerrit-Comment-Date: Wed, 12 Jun 2024 08:58:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: daniel <[email protected]> Gerrit-MessageType: comment
