Attention is currently required from: daniel, pespin.

osmith has posted comments on this change. ( 
https://gerrit.osmocom.org/c/docker-playground/+/37192?usp=email )

Change subject: jenkins-common: Treat -asan builds the same as -master
......................................................................


Patch Set 2:

(1 comment)

File jenkins-common.sh:

https://gerrit.osmocom.org/c/docker-playground/+/37192/comment/fbb35a81_7a0a80e4
PS1, Line 548: image_suffix_is_master() {
> Ack
I would really name it "osmo_repo_is_nightly", not "image_suffix_is_nightly". 
Because the IMAGE_SUFFIX variable is something else, and it is not set to 
"nightly", it is set to "master" / "asan".



--
To view, visit https://gerrit.osmocom.org/c/docker-playground/+/37192?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-Change-Id: Ibf93880345f38668f8dc812d1523b985d368dfcc
Gerrit-Change-Number: 37192
Gerrit-PatchSet: 2
Gerrit-Owner: daniel <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <[email protected]>
Gerrit-Reviewer: pespin <[email protected]>
Gerrit-Attention: pespin <[email protected]>
Gerrit-Attention: daniel <[email protected]>
Gerrit-Comment-Date: Wed, 12 Jun 2024 10:47:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith <[email protected]>
Comment-In-Reply-To: daniel <[email protected]>
Gerrit-MessageType: comment

Reply via email to