Attention is currently required from: jolly, pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37194?usp=email )
Change subject: asterisk: Test initial IMS REGISTER timeout ...................................................................... Patch Set 2: (3 comments) File asterisk/Asterisk_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37194/comment/4864920c_92cf3cb3 PS2, Line 51: /* Current default by pjproject (timeout_timer_val) to 32s, and not changed by Asterisk */ the comment doesn't seem to be a valid sentence? https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37194/comment/12c978c3_c8b492ee PS2, Line 52: integer mp_volte_ims_outbound_register_timeout := 32; (wouldn't a float make more sense, since titan handles all timers in float? does it have to be limited to full integer values for some reason?) File asterisk/IMS_ConnectionHandler.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37194/comment/8c4b1484_eaf9943b PS2, Line 211: t_guard := 60.0, in some test suites we can set individual test timeouts to a larger value by f_init(t_guard := 60.0) -- this here seems to generally double the time it takes to fail pre-existing tests by timeout? -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37194?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: If59d43b2779dfbd14890a88d664077c194f843a1 Gerrit-Change-Number: 37194 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <[email protected]> Gerrit-CC: neels <[email protected]> Gerrit-Attention: jolly <[email protected]> Gerrit-Attention: pespin <[email protected]> Gerrit-Comment-Date: Mon, 17 Jun 2024 02:10:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
