Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/37238?usp=email )
Change subject: smpp: fix password[] length in struct esme ...................................................................... Patch Set 1: Code-Review+2 (1 comment) File include/osmocom/smpp/smpp.h: https://gerrit.osmocom.org/c/osmo-msc/+/37238/comment/8fa6c998_3b1bf346 PS1, Line 26: char password[SMPP_PASSWD_LEN + 1]; > this is probably breaking the ABI, better add it to TODO-RELEASE Ah nevermind, this is not within libsmpp34 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/37238?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I07e7193460580a3c972a24700e75c925d1e50411 Gerrit-Change-Number: 37238 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-Attention: fixeria <[email protected]> Gerrit-Comment-Date: Tue, 18 Jun 2024 10:52:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: pespin <[email protected]> Gerrit-MessageType: comment
