Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/37247?usp=email )
Change subject: ttcn3-s1gw-test: align with the moduleparam naming changes ...................................................................... Patch Set 1: (1 comment) File ttcn3-s1gw-test/S1GW_Tests.cfg: https://gerrit.osmocom.org/c/docker-playground/+/37247/comment/70c1b22d_fb0bdbe9 PS1, Line 11: S1GW_Tests.mp_s1gw_mme_ip := "172.18.10.001"; > why adding those extra leading zeroes? feels confusing tbh, I never saw that > in an IP address repres […] Purely cosmetic reason: for alignment with the other two addresses. It works. But I'll remove the leading zeros anyway to avoid confusion. -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/37247?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I37b7d91e9e18df463f54cac3e5586942aea21a69 Gerrit-Change-Number: 37247 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <[email protected]> Gerrit-Attention: pespin <[email protected]> Gerrit-Comment-Date: Tue, 18 Jun 2024 19:01:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <[email protected]> Gerrit-MessageType: comment
