Attention is currently required from: pespin. falconia has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/37250?usp=email )
Change subject: rtp2trau_hr16: use osmo_hr_check_sid() ...................................................................... Patch Set 1: (1 comment) File TODO-RELEASE: https://gerrit.osmocom.org/c/libosmo-abis/+/37250/comment/b0af0a54_955a4fbe PS1, Line 12: libosmocodec >1.9.0 bugfix in osmo_hr_check_sid() in case length=0 > the useful hint here is actually ABI/API related, so the interesting info you > should add here in dec […] It is not clear to me exactly how to describe the relevant API aspect here - please help me. The issue is: * osmo_hr_check_sid() API has been there for ages; * it was previously broken (returned true on zero-length input, when the correct answer should be false); * the recent change in libosmocore repo fixed it; * the present libosmo-abis change depends on that fix. What is the correct way to express this dependency on the logic fix in the old API? -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/37250?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: Ia8fe7e9ea65fadf7f5c136355ca8c24c89f09ef2 Gerrit-Change-Number: 37250 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <[email protected]> Gerrit-Attention: pespin <[email protected]> Gerrit-Comment-Date: Tue, 18 Jun 2024 19:54:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <[email protected]> Gerrit-MessageType: comment
