Attention is currently required from: neels. lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/simtrace2/+/36981?usp=email )
Change subject: firmware: allow to change the sim presence pin polarity ...................................................................... Patch Set 6: (4 comments) Commit Message: https://gerrit.osmocom.org/c/simtrace2/+/36981/comment/47ffa020_5eb8442a PS6, Line 12: n > "Even though" ? Done Patchset: PS6: > rather fix the "prensence" typo in the symbol name before merging (see > in-line comment). […] Done File firmware/libcommon/include/simtrace.h: https://gerrit.osmocom.org/c/simtrace2/+/36981/comment/a09b351a_9c9b102a PS6, Line 128: prensence > typo in the name, should be "_presence_" […] Done File firmware/libcommon/include/simtrace_prot.h: https://gerrit.osmocom.org/c/simtrace2/+/36981/comment/e84e6b4d_7b11bbbb PS6, Line 274: is valid bit > maybe "is a validity bit" or "indicates validity"? Done -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/36981?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: I77118114ba873fdf0778137402888b40f2442456 Gerrit-Change-Number: 36981 Gerrit-PatchSet: 6 Gerrit-Owner: lynxis lazus <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: neels <[email protected]> Gerrit-Attention: neels <[email protected]> Gerrit-Comment-Date: Sun, 23 Jun 2024 16:47:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <[email protected]> Gerrit-MessageType: comment
