Attention is currently required from: pespin.

dexter has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37470?usp=email )

Change subject: IPAd_Tests: rework verification of ESipa responses from IPAd
......................................................................


Patch Set 2:

(1 comment)

File ipad/IPAd_Tests.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37470/comment/58b32621_a2603ff8 
PS1, Line 450:  if (not match(esipa_req, 
tr_getBoundProfilePackageRequestEsipa)) {
> I'd really go for adding this check in a new api, you'll use this several 
> times:  […]
Thanks for the hint. This was a great idea. I also fixed it in the eIM 
testsuite.



--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37470?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I0150fe5c98d5a5db9f1931c72ef6e015f74055bd
Gerrit-Change-Number: 37470
Gerrit-PatchSet: 2
Gerrit-Owner: dexter <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <[email protected]>
Gerrit-Attention: pespin <[email protected]>
Gerrit-Comment-Date: Fri, 12 Jul 2024 13:15:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <[email protected]>
Gerrit-MessageType: comment

Reply via email to