Attention is currently required from: dexter.

laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/pysim/+/37497?usp=email )

Change subject: osmo-smdpp: Make sure to return empty HTTP response in 
handleNotification
......................................................................


Patch Set 3: Code-Review+2

(1 comment)

File osmo-smdpp.py:

https://gerrit.osmocom.org/c/pysim/+/37497/comment/351c2979_03c5b4a4
PS2, Line 191:                 return ''
> May it makes sens to print something like "Tx (empty response)" for 
> consistency?
mh, I'm not convinced, sorry.



--
To view, visit https://gerrit.osmocom.org/c/pysim/+/37497?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I1cad539accbc3e7222bfd4780955b3b1ff694c5b
Gerrit-Change-Number: 37497
Gerrit-PatchSet: 3
Gerrit-Owner: laforge <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <[email protected]>
Gerrit-Reviewer: fixeria <[email protected]>
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-Attention: dexter <[email protected]>
Gerrit-Comment-Date: Wed, 17 Jul 2024 13:23:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: dexter <[email protected]>
Gerrit-MessageType: comment

Reply via email to