Attention is currently required from: dexter, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/37548?usp=email )
Change subject: pcuif_sock: do not retry when sending PCU version ...................................................................... Patch Set 2: (1 comment) File src/pcuif_sock.c: https://gerrit.osmocom.org/c/osmo-pcu/+/37548/comment/e5cca76d_debe5baf PS2, Line 245: osmo_timer_schedule(&pcu_sock_state.timer, 5, 0); > And I guess you also need to remove the timer from the struct now that it's > not used anymore? @[email protected] it's also used for re-connection, check code carefully. -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/37548?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Iddd3eed113ed288e629b6029f9a56de427de8126 Gerrit-Change-Number: 37548 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-Attention: pespin <[email protected]> Gerrit-Attention: dexter <[email protected]> Gerrit-Comment-Date: Tue, 23 Jul 2024 10:14:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <[email protected]> Gerrit-MessageType: comment
