laforge has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/pysim/+/37621?usp=email )


Change subject: pySim.runtime: Be more verbose if incompatible method is called
......................................................................

pySim.runtime: Be more verbose if incompatible method is called

Change-Id: I57190d50a63e0c22a8c5921e1348fae31b23e3d4
---
M pySim/runtime.py
1 file changed, 21 insertions(+), 6 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/21/37621/1

diff --git a/pySim/runtime.py b/pySim/runtime.py
index a56d884..22845bc 100644
--- a/pySim/runtime.py
+++ b/pySim/runtime.py
@@ -423,7 +423,8 @@
             binary data read from the file
         """
         if not isinstance(self.selected_file, TransparentEF):
-            raise TypeError("Only works with TransparentEF")
+            raise TypeError("Only works with TransparentEF, but %s is %s" % 
(self.selected_file,
+                                                                             
self.selected_file.__class__.__mro__))
         return self.scc.read_binary(self.selected_file.fid, length, offset)

     def read_binary_dec(self) -> Tuple[dict, str]:
@@ -447,7 +448,8 @@
             offset : Offset into the file from which to write 'data_hex'
         """
         if not isinstance(self.selected_file, TransparentEF):
-            raise TypeError("Only works with TransparentEF")
+            raise TypeError("Only works with TransparentEF, but %s is %s" % 
(self.selected_file,
+                                                                             
self.selected_file.__class__.__mro__))
         return self.scc.update_binary(self.selected_file.fid, data_hex, 
offset, conserve=self.rs.conserve_write)

     def update_binary_dec(self, data: dict):
@@ -469,7 +471,8 @@
             hex string of binary data contained in record
         """
         if not isinstance(self.selected_file, LinFixedEF):
-            raise TypeError("Only works with Linear Fixed EF")
+            raise TypeError("Only works with Linear Fixed EF, but %s is %s" % 
(self.selected_file,
+                                                                               
self.selected_file.__class__.__mro__))
         # returns a string of hex nibbles
         return self.scc.read_record(self.selected_file.fid, rec_nr)

@@ -492,7 +495,8 @@
             data_hex : Hex string binary data to be written
         """
         if not isinstance(self.selected_file, LinFixedEF):
-            raise TypeError("Only works with Linear Fixed EF")
+            raise TypeError("Only works with Linear Fixed EF, but %s is %s" % 
(self.selected_file,
+                                                                               
self.selected_file.__class__.__mro__))
         return self.scc.update_record(self.selected_file.fid, rec_nr, data_hex,
                                               conserve=self.rs.conserve_write,
                                               
leftpad=self.selected_file.leftpad)
@@ -528,7 +532,8 @@
             list of integer tags contained in EF
         """
         if not isinstance(self.selected_file, BerTlvEF):
-            raise TypeError("Only works with BER-TLV EF")
+            raise TypeError("Only works with BER-TLV EF, but %s is %s" % 
(self.selected_file,
+                                                                          
self.selected_file.__class__.__mro__))
         data, _sw = self.scc.retrieve_data(self.selected_file.fid, 0x5c)
         _tag, _length, value, _remainder = bertlv_parse_one(h2b(data))
         return list(value)
@@ -541,7 +546,8 @@
             data_hex : Hex string binary data to be written (value portion)
         """
         if not isinstance(self.selected_file, BerTlvEF):
-            raise TypeError("Only works with BER-TLV EF")
+            raise TypeError("Only works with BER-TLV EF, but %s is %s" % 
(self.selected_file,
+                                                                          
self.selected_file.__class__.__mro__))
         return self.scc.set_data(self.selected_file.fid, tag, data_hex, 
conserve=self.rs.conserve_write)

     def unregister_cmds(self, cmd_app=None):

--
To view, visit https://gerrit.osmocom.org/c/pysim/+/37621?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I57190d50a63e0c22a8c5921e1348fae31b23e3d4
Gerrit-Change-Number: 37621
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <[email protected]>
Gerrit-MessageType: newchange

Reply via email to