Attention is currently required from: fixeria, osmith.

pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37634?usp=email )

Change subject: Improve use of enumareted type GTP_Clause
......................................................................


Patch Set 1:

(1 comment)

File library/GTPv1C_Templates.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37634/comment/0a080b5c_cdae35bf 
PS1, Line 74:   } with { encode "RAW"
            :
> Is this really needed? doesn't `enum2int()` work without it?
I got a compilation error under some uses of this enum, and having the encode 
"RAW" fixed it. It may not be needed with final uses, but it doesn't hurt 
anyway.



--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37634?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ib071fa97a354cb27263cd46dba8f468b4ddc0018
Gerrit-Change-Number: 37634
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <[email protected]>
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-Reviewer: osmith <[email protected]>
Gerrit-Attention: osmith <[email protected]>
Gerrit-Attention: fixeria <[email protected]>
Gerrit-Comment-Date: Mon, 29 Jul 2024 08:29:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <[email protected]>
Gerrit-MessageType: comment

Reply via email to