Attention is currently required from: fixeria, laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37645?usp=email )
Change subject: library/GTPv1U_Templates: Mark parameters as templates ...................................................................... Patch Set 2: (4 comments) File library/GTPv1U_Templates.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37645/comment/2b790366_13532b56 PS1, Line 58: template (value) > What do we win by doing so? IMO, template parameters are useful for complex > parameters, like records […] It helps in easying the posibility to pass both values and template. This way also one doesn't need to be calling valueof() everytime it uses the template. After lots of cleanup of errors and use cases I find this the best approach: Keep using tmeplate parameters for parent template parameters, until an explicit value is required. https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37645/comment/5f62d481_c52e4168 PS1, Line 61: template (value) GTPU_IEs ies > It's fine making this one a template param, so that you can pass templates > like `ts_UEchoReqPDU` dir […] It doesn't cause a problem either, and allows for more freedom to the caller/user of the template. https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37645/comment/8d36a78c_cf7e2055 PS1, Line 122: valueof(ts_UEchoReqPDU > ... so you turned this param into a template, but still doing unnecessary > `valueof()`. I forgot these ones, I'm cleaning them up now. https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37645/comment/ae8c9bea_083d50d3 PS1, Line 145: valueof(ip_addr) > ... […] See my first comment. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37645?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I278f7dbc64704c1ba2b8a75d6f540ac52b067598 Gerrit-Change-Number: 37645 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <[email protected]> Gerrit-Reviewer: laforge <[email protected]> Gerrit-Attention: laforge <[email protected]> Gerrit-Attention: fixeria <[email protected]> Gerrit-Comment-Date: Mon, 29 Jul 2024 08:42:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <[email protected]> Gerrit-MessageType: comment
