Attention is currently required from: falconia, laforge, osmith, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/37558?usp=email )
Change subject: codec: add osmo_hr_sid_classify() ...................................................................... Patch Set 3: Code-Review+1 (2 comments) File src/codec/hr_sid_class.c: https://gerrit.osmocom.org/c/libosmocore/+/37558/comment/f2b95218_091039e1 PS2, Line 31: static unsigned ones_in_byte(uint8_t byte) > The least powerful BTS CPU we need to support is ARM926EJS on sysmoBTS. […] Done https://gerrit.osmocom.org/c/libosmocore/+/37558/comment/ba3920ce_de6eb663 PS2, Line 35: for (; byte; byte >>= 1) { > Thanks for the recommendation - I will implement it in the next revision of > this patch. Done -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/37558?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I5f4eb65379646125b966cf182775b6e9348900bd Gerrit-Change-Number: 37558 Gerrit-PatchSet: 3 Gerrit-Owner: falconia <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <[email protected]> Gerrit-Reviewer: laforge <[email protected]> Gerrit-CC: osmith <[email protected]> Gerrit-CC: pespin <[email protected]> Gerrit-Attention: osmith <[email protected]> Gerrit-Attention: falconia <[email protected]> Gerrit-Attention: laforge <[email protected]> Gerrit-Attention: pespin <[email protected]> Gerrit-Comment-Date: Mon, 29 Jul 2024 20:58:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: falconia <[email protected]> Comment-In-Reply-To: fixeria <[email protected]> Comment-In-Reply-To: pespin <[email protected]> Gerrit-MessageType: comment
