Patch Set 4: Code-Review+1 (1 comment)
fine with me, if we add that extra 'void * ctx' argument to the unlink function. https://gerrit.osmocom.org/#/c/5832/4/src/fsm.c File src/fsm.c: Line 285: talloc_steal(NULL, fi); I think it makes sense to pass in the new talloc context as argument to osmo_fsm_inst_unlink_parent. The normal caller would then simply call it with the NULL argument, and those who want to specify the new context can do so. -- To view, visit https://gerrit.osmocom.org/5832 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6d18cbd4ada903cf3720b3ad2a89fc643085beef Gerrit-PatchSet: 4 Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Owner: dexter <pma...@sysmocom.de> Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org> Gerrit-Reviewer: Jenkins Builder Gerrit-HasComments: Yes
