Attention is currently required from: daniel, fixeria, laforge, pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37694?usp=email )
Change subject: testenv: add test environment script ...................................................................... Patch Set 3: (5 comments) File _testenv/data/podman/Dockerfile: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37694/comment/368c33f5_43a7fc87 PS2, Line 94: python3 setup.py clean build install > we should finally start using `pip install`, since running `setup. […] Done File _testenv/data/podman/seccomp_profile.json: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37694/comment/712a2e2b_d52a21be PS2, Line 20: "subArchitectures": [ > is this file a modified file from some other source? If yes, then I would > appreciate if we can chec […] Done File _testenv/data/scripts/rename_junit_xml_classname.sh: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37694/comment/cdc17970_eb1b5b9b PS2, Line 1: #!/bin/sh -e > maybe 1-2 line description on top of the file what it does? Yes, rename > something - but why and how […] Done File _testenv/testenv.py: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37694/comment/59154094_58897c02 PS2, Line 2: import logging > please add some kind of copyright statement, license header and summary > description to all of the py […] Done File _testenv/testenv/osmo_dev.py: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37694/comment/3a969f1a_a3fdc371 PS2, Line 49: logging.error(testenv.src_dir) > I see a some line wrapping that looks like its way before we hit the 120 > character max line length o […] Done -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37694?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: If9f8b79dd6e5b4f06be4e5ff73db97759c3acfb2 Gerrit-Change-Number: 37694 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <[email protected]> Gerrit-Reviewer: fixeria <[email protected]> Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-Attention: laforge <[email protected]> Gerrit-Attention: fixeria <[email protected]> Gerrit-Attention: pespin <[email protected]> Gerrit-Attention: daniel <[email protected]> Gerrit-Comment-Date: Fri, 02 Aug 2024 11:25:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <[email protected]> Comment-In-Reply-To: fixeria <[email protected]> Gerrit-MessageType: comment
